Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support to pass file path in mapping #58

Merged
merged 2 commits into from
Dec 2, 2022
Merged

Adds support to pass file path in mapping #58

merged 2 commits into from
Dec 2, 2022

Conversation

fruit
Copy link
Contributor

@fruit fruit commented Nov 19, 2022

SEMVER Update Type:

  • Major
  • Minor
  • Patch

Description:

Reused "mapping" property to support file path to read mapping from.

Motivation:

I would like to have a auto-mapping, i.e. adding a new folder should automatically start monitoring changes in it. To do it I have created a job which
generates mappings in required format and then passes it to path-filtering command via mapping property. Changes are back-compatible with existing
setup.

Closes Issues:

  • No such

Checklist:

  • All new jobs, commands, executors, parameters have descriptions.
  • Usage Example version numbers have been updated.
  • Changelog has been updated.

@fruit fruit marked this pull request as ready for review November 19, 2022 22:00
@JadhavPoonam JadhavPoonam self-assigned this Dec 1, 2022
JadhavPoonam
JadhavPoonam approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@JadhavPoonam JadhavPoonam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with the dev version and LGTM.

@JadhavPoonam JadhavPoonam merged commit 28645d2 into CircleCI-Public:main Dec 2, 2022
@fruit fruit deleted the feat-support-for-file-path-in-mapping branch December 3, 2022 19:59
@fruit
Copy link
Contributor Author

fruit commented Jan 13, 2023

Hi @JadhavPoonam!

Could you please create a tag in order to install this PR changes via CircleCI config orbs: section?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JadhavPoonam JadhavPoonam JadhavPoonam approved these changes

Assignees

@JadhavPoonam JadhavPoonam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fruit @JadhavPoonam