Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrich github prompt to capture organization ID for GitHub App integr… #1027

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

bjohnso5
Copy link
Contributor

@bjohnso5 bjohnso5 commented Dec 14, 2023

…ation users

Checklist

=========

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Internal Checklist

  • I am requesting a review from my own team as well as the owning team
  • I have a plan in place for the monitoring of the changes that I am making (this can include new monitors, logs to be aware of, etc...)

Changes

  • Add instructions for GH App integration users to use the organization ID in place of the organization name on orb creation

Rationale

Organizations that are using GitHub App integration with CircleCI must use their organization ID rather than name when interacting with the orb commands in the CLI

@bjohnso5 bjohnso5 requested review from a team as code owners December 14, 2023 17:38
@bjohnso5 bjohnso5 changed the base branch from develop to main December 14, 2023 17:52
@bjohnso5 bjohnso5 merged commit dd6a5b1 into main Dec 14, 2023
1 check passed
@bjohnso5 bjohnso5 deleted the orbs/support-gh-apps-organizations branch December 14, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants