Prevent asterisk expansion when asterisk is present in task definition value [semver:patch]

[lokst]

This is a fix for #89.
"set -o noglob" is used to prevent unwanted expansion of asterisks present in task definitions, by the shell.
.circleci/config.yml has also been updated so that the integration tests include a test for the fix.

Sample test: https://circleci.com/gh/CircleCI-Public/aws-ecs-orb/2620

[FelicianoTech]

This looks like it works to me. Quick question though.

Is set -o noglob actually needed? Sometimes double quotes (added in line 661 for example) are enough. In Bash, adding single quotes to a line means to not interpret anything and treat the characters literally. Would using single quotes here be enough or do you think turning off globbing is necessary?

[KyleTryon]

This looks like it works to me. Quick question though.

Is set -o noglob actually needed? Sometimes double quotes (added in line 661 for example) are enough. In Bash, adding single quotes to a line means to not interpret anything and treat the characters literally. Would using single quotes here be enough or do you think turning off globbing is necessary?

Agreeing with this. The <</>> replacement will still happen before the single quotes are interpreted, so I believe using single quotes would also solve this.

[lokst]

Thanks for the feedback @FelicianoTech @KyleTryon! I agree that quoting should be adequate; the turning off of globbing here was intended as a quick fix that can be revisited in favor of a better solution that ensures quotes are used in all places needing them.