Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use assertIsNone instead of assertEquals #46

Merged
merged 4 commits into from
Oct 9, 2019
Merged

use assertIsNone instead of assertEquals #46

merged 4 commits into from
Oct 9, 2019

Conversation

StrikerRUS
Copy link
Contributor

PEP8 explicitly states that

Comparisons to singletons like None should always be done with is or is not, never the equality operators.
https://www.python.org/dev/peps/pep-0008/#programming-recommendations

lokst
lokst approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@lokst lokst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StrikerRUS Thanks for this!

@lokst lokst merged commit 47de888 into CircleCI-Public:master Oct 9, 2019
@lokst lokst added this to the 0.0.18 milestone Oct 9, 2019
@lokst lokst added the enhancement New feature or request label Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lokst lokst lokst approved these changes

@iynere iynere Awaiting requested review from iynere

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.0.18
Development

Successfully merging this pull request may close these issues.
2 participants
@StrikerRUS @lokst