Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix jq command when working with an existing Docker config.json file #334

Merged

Conversation

ahamilton55
Copy link
Contributor

Checklist

  • All new jobs, commands, executors, parameters have descriptions (not needed)
  • Examples have been added for any significant new features (not needed)
  • README has been updated, if necessary (not needed)

Motivation, issues

Fixes #333

The change is needed to update the ${HOME}/.docker/config.json file to with multiple ECR entries. The jq command currently fails when attempting to add a second ECR entry.

Description

Removes double quotes around the $jq_flag so that it is properly handled when it is empty. With the double quotes, the jq command is interpreting the empty string as a parameter and then failing to find the config file because of how it is parsing the flags.

I also fix the indentation of the jq command so that the staring matches the level of the if statement above it and indent the additional parts of the jq command a couple extra spaces.

@ahamilton55 ahamilton55 requested a review from a team as a code owner March 5, 2024 20:44
@brentmmarks brentmmarks merged commit 08770f8 into CircleCI-Public:master Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot login to multiple ECRs with version 9.0.3
2 participants