fix: fix jq command when working with an existing Docker config.json file #334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Motivation, issues
Fixes #333
The change is needed to update the
${HOME}/.docker/config.json
file to with multiple ECR entries. Thejq
command currently fails when attempting to add a second ECR entry.Description
Removes double quotes around the
$jq_flag
so that it is properly handled when it is empty. With the double quotes, thejq
command is interpreting the empty string as a parameter and then failing to find the config file because of how it is parsing the flags.I also fix the indentation of the
jq
command so that the staring matches the level of theif
statement above it and indent the additional parts of thejq
command a couple extra spaces.