Skip to content

Commit

Permalink
Fix examples (#369)
Browse files Browse the repository at this point in the history
* Fix examplesW

* Fix name of registry_login parameter
  • Loading branch information
marboledacci authored Nov 21, 2024
1 parent 94bd383 commit ec740b0
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions src/examples/build_and_push_image_w_registry_login.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@ usage:
orbs:
aws-ecr: circleci/aws-ecr@9.0
# importing aws-cli orb is required for authentication
aws-cli: circleci/aws-cli@4.0
aws-cli: circleci/aws-cli@5.1
workflows:
build-and-push-image-with-container-registry-login:
jobs:
- aws-ecr/build_and_push_image:
# must set container registry login to true
container_registry_login: true
container_registry_login_step:
registry_login:
# custom login step for heroku.
- run: docker login -u ${HEROKU_USERNAME} -p ${HEROKU_API_KEY}
# custom login step for GitHub Container Registry.
Expand Down
2 changes: 1 addition & 1 deletion src/examples/build_test_then_push_image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ usage:
orbs:
aws-ecr: circleci/aws-ecr@9.0
# importing aws-cli orb is required for authentication
aws-cli: circleci/aws-cli@4.0
aws-cli: circleci/aws-cli@5.1
jobs:
build-test-then-push-with-buildx:
machine:
Expand Down
4 changes: 2 additions & 2 deletions src/examples/simple_build_and_push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ usage:
orbs:
aws-ecr: circleci/aws-ecr@9.0
# Importing aws-cli orb is required
aws-cli: circleci/aws-cli@4.0
aws-cli: circleci/aws-cli@5.1

executors:
base:
Expand All @@ -23,7 +23,7 @@ usage:
auth:
# Add authentication step with OIDC using aws-cli/setup command
- aws-cli/setup:
profile: "OIDC-USER"
profile_name: "OIDC-USER"
role_arn: "arn:aws:iam::123456789012:role/VALID_OIDC_ECR_ROLE"

# Must use same profile configured in aws-cli/setup command
Expand Down

0 comments on commit ec740b0

Please sign in to comment.