remove notebook, modify prepare output method

Cinnamon · Jan 6, 2025 · a016a28 · a016a28
1 parent 3ebc021
commit a016a28
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 166 deletions.
diff --git a/libs/kotaemon/kotaemon/llms/chats/openai.py b/libs/kotaemon/kotaemon/llms/chats/openai.py
@@ -340,11 +340,6 @@ def prepare_output(self, resp: dict) -> StructuredOutputLLMInterface:
         """Convert the OpenAI response into StructuredOutputLLMInterface"""
         additional_kwargs = {}
 
-        if 'parsed' in resp['choices'][0]['message']:
-            additional_kwargs['parsed'] = resp["choices"][0]["message"][
-                "parsed"
-            ]
-
         if "tool_calls" in resp["choices"][0]["message"]:
             additional_kwargs["tool_calls"] = resp["choices"][0]["message"][
                 "tool_calls"
@@ -359,7 +354,7 @@ def prepare_output(self, resp: dict) -> StructuredOutputLLMInterface:
             )
 
         output = StructuredOutputLLMInterface(
-            **additional_kwargs, # TODO: clarify how additional_kwargs is used - diff bw BaseChatOpenAI usage and here 
+            parsed = resp["choices"][0]["message"]["parsed"],
             candidates=[(_["message"]["content"] or "") for _ in resp["choices"]],
             content=resp["choices"][0]["message"]["content"] or "",
             total_tokens=resp["usage"]["total_tokens"],
@@ -369,6 +364,7 @@ def prepare_output(self, resp: dict) -> StructuredOutputLLMInterface:
                 AIMessage(content=(_["message"]["content"]) or "")
                 for _ in resp["choices"]
             ],
+            additional_kwargs=additional_kwargs,
             logprobs=logprobs,
 
         )

diff --git a/libs/kotaemon/test_structured_output.ipynb b/libs/kotaemon/test_structured_output.ipynb