Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Number of Groups in Group list doesn't match with Groups cou… #7168

Merged
merged 3 commits into from
Sep 28, 2024

Conversation

bigtigerku
Copy link
Contributor

@bigtigerku bigtigerku commented Sep 27, 2024

…nt in Dashboard

Description & Issue number it closes

#3985

Screenshots (if appropriate)

Before

Dashboard says 17 groups.

Screenshot 2024-09-27 at 4 20 05 PM

Group list says 23 entries.

Screenshot 2024-09-27 at 4 20 18 PM

After

Screenshot 2024-09-27 at 10 59 50 AM Screenshot 2024-09-27 at 11 00 02 AM Screenshot 2024-09-27 at 11 00 13 AM

How to test the changes?

Number of groups in the Dashboard and Group List should be the same like the above screenshots.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Docker

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bigtigerku bigtigerku requested a review from a team as a code owner September 27, 2024 18:03
@bigtigerku bigtigerku requested review from respencer, DawoudIO, grayeul, DAcodedBEAT and MrClever and removed request for a team September 27, 2024 18:03
@DAcodedBEAT
Copy link
Contributor

Do you think it's worth writing a test for this?

@bigtigerku
Copy link
Contributor Author

Do you think it's worth writing a test for this?

This is a change of how to count groups. Details are at #3985 (comment)
I am not sure how to test this 😅

@DawoudIO DawoudIO added this to the 5.11.0 milestone Sep 28, 2024
@DawoudIO
Copy link
Contributor

So this change will always count Sunday school groups... which is guess is ok

{
tf = document.getElementById("table-filter");
tf.selectedIndex = gS;
<script nonce="<?= SystemURLs::getCSPNonce() ?>"></script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should kill this as it has no value

@DawoudIO DawoudIO merged commit 1b3950d into ChurchCRM:master Sep 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants