Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep counter Totals first for Event Types #7065

Conversation

respencer
Copy link
Contributor

Description & Issue number it closes

Resolves #2771

Screenshots (if appropriate)

None.

How to test the changes?

Visual inspection.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Visual inspection.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@respencer respencer requested a review from a team as a code owner June 3, 2024 14:09
@respencer respencer requested review from DawoudIO, grayeul, DAcodedBEAT and MrClever and removed request for a team June 3, 2024 14:09
@respencer respencer force-pushed the 2771-keep-counter-totals-first-for-event-types branch from 3ed11a2 to cf8a173 Compare June 5, 2024 07:12
@respencer respencer force-pushed the 2771-keep-counter-totals-first-for-event-types branch 2 times, most recently from 6c6cf81 to b31b4dd Compare June 11, 2024 07:35
@respencer respencer force-pushed the 2771-keep-counter-totals-first-for-event-types branch from b31b4dd to 31059d2 Compare June 12, 2024 06:41
@DAcodedBEAT DAcodedBEAT merged commit 07f689f into ChurchCRM:master Jun 12, 2024
3 checks passed
@DAcodedBEAT DAcodedBEAT added bug php Pull requests that update Php code labels Jun 12, 2024
@respencer respencer deleted the 2771-keep-counter-totals-first-for-event-types branch June 12, 2024 13:21
@DAcodedBEAT DAcodedBEAT added this to the 5.9.0 milestone Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep counter Totals first for Event Types
3 participants