-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various issues on shared hosting #7059
Fix various issues on shared hosting #7059
Conversation
} | ||
|
||
$logger->debug('Integrity check result file not found at: ' . $integrityCheckFile); | ||
|
||
AppIntegrityService::$IntegrityCheckDetails = new \stdClass(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use a structured object instead of a generic stdclass?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately I don't know what exactly you want here instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of using \stdClass
, we should make a new IntegrityCheckResults
class with all of the expected fields. Right now, any field can be added to this plain stdclass and each of it's properties are undocumented, which makes it difficult to see what is being used and where.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(we can defer this change if you want but if we do, can you make a Github issue for tracking?)
3018c73
to
a76bc5f
Compare
a76bc5f
to
8ad2d8c
Compare
8ad2d8c
to
a6194d9
Compare
Description & Issue number it closes
apache_get_modules
notice.htaccess
from change validation (it frequently needs to be changed on shared hosting)Resolves #7056
Screenshots (if appropriate)
How to test the changes?
Type of change
How Has This Been Tested?
Checklist: