Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PersonEditor cleanup pt1 #7053

Merged
merged 3 commits into from
May 27, 2024
Merged

PersonEditor cleanup pt1 #7053

merged 3 commits into from
May 27, 2024

Conversation

DAcodedBEAT
Copy link
Contributor

Description & Issue number it closes

This PR refactors PersonEditor.php to enhance code readability and maintainability by replacing raw SQL queries with ORM methods and streamlining the person and family data handling processes.

Key Changes:

  1. Replaced raw SQL queries with ORM methods.
  2. Improved PersonID and FamilyID handling.
  3. Enhanced security with streamlined permission checks.
  4. Simplified form submission and custom field handling.

Benefits:

  • Better code readability and maintainability.
  • Enhanced security and reduced SQL injection risk.

Please review and provide feedback, thanks!

Screenshots (if appropriate)

N/A

How to test the changes?

  • Verified adding/updating person and family records.
  • Ensured security checks work correctly.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@DAcodedBEAT DAcodedBEAT added Feature: Users Security Code Smell php Pull requests that update Php code labels May 25, 2024
@DAcodedBEAT DAcodedBEAT self-assigned this May 25, 2024
@DAcodedBEAT DAcodedBEAT marked this pull request as ready for review May 26, 2024 03:42
@DAcodedBEAT DAcodedBEAT requested a review from a team as a code owner May 26, 2024 03:42
@DAcodedBEAT DAcodedBEAT requested review from respencer, DawoudIO, grayeul and MrClever and removed request for a team May 26, 2024 03:42
@DAcodedBEAT DAcodedBEAT added this to the vNext (5.9.0) milestone May 26, 2024
@DAcodedBEAT DAcodedBEAT force-pushed the personeditor-cleanup-pt1 branch 2 times, most recently from 7101471 to b9b3504 Compare May 27, 2024 15:57
@DAcodedBEAT DAcodedBEAT merged commit e3fd3c9 into master May 27, 2024
6 checks passed
@DAcodedBEAT DAcodedBEAT deleted the personeditor-cleanup-pt1 branch May 27, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@respencer respencer respencer approved these changes

@DawoudIO DawoudIO Awaiting requested review from DawoudIO DawoudIO is a code owner automatically assigned from ChurchCRM/developers

@grayeul grayeul Awaiting requested review from grayeul grayeul is a code owner automatically assigned from ChurchCRM/developers

@MrClever MrClever Awaiting requested review from MrClever MrClever is a code owner automatically assigned from ChurchCRM/developers

Assignees

@DAcodedBEAT DAcodedBEAT

Labels
Code Smell Feature: Users php Pull requests that update Php code Security
Projects
None yet
Milestone
5.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DAcodedBEAT @respencer