Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix awkwardly translated string #7048

Merged
merged 5 commits into from
Jun 15, 2024

Conversation

respencer
Copy link
Contributor

Description & Issue number it closes

Resolves #2776

Screenshots (if appropriate)

Before:

Screen Shot 2024-05-24 at 18 02 42

After:

Screen Shot 2024-05-24 at 18 08 07

How to test the changes?

Visual inspection.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Visual inspection.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@respencer respencer requested a review from a team as a code owner May 24, 2024 16:11
@respencer respencer requested review from DawoudIO, grayeul, DAcodedBEAT and MrClever and removed request for a team May 24, 2024 16:11
Copy link
Contributor

@DawoudIO DawoudIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not merge

@DAcodedBEAT
Copy link
Contributor

Please do not merge

@DawoudIO is there a reason for blocking this? If possible, I think code reviews should be as descriptive as possible and your response doesn't indicate what is wrong with the suggested change.

@respencer respencer force-pushed the 2776-awkward-translated-string branch from d2f4337 to 8f74fb4 Compare May 27, 2024 09:48
@respencer respencer requested a review from DawoudIO May 28, 2024 07:42
@respencer
Copy link
Contributor Author

@DawoudIO: Do I need to abandon this PR?

@respencer respencer closed this Jun 12, 2024
@DawoudIO
Copy link
Contributor

No, sorry for putting it on hold... I think "MailChimp is not configured" should remain as "is not configured," but I understand that some languages have different placements for it... I'm ok moving forward with it

@DawoudIO DawoudIO reopened this Jun 15, 2024
@DawoudIO
Copy link
Contributor

We need to document the following:

  1. we need to run the following command npm run locale-gen to regen the new file
  2. upload the locale/messages.po to poeditor.com to update the terms, and delete any unused terms.
  3. download the result via daily poeditor download or npm run locale-download if you have the poeditor API key

@DawoudIO DawoudIO merged commit 54d08de into ChurchCRM:master Jun 15, 2024
3 checks passed
@respencer respencer deleted the 2776-awkward-translated-string branch June 17, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Awkward tranlsated string
3 participants