Feature: Menu external links #4053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
crossan007
reviewed
Mar 5, 2018
| CREATE TABLE `menu_links` ( | ||
| `linkId` mediumint(8) unsigned NOT NULL AUTO_INCREMENT, | ||
| `linkName` varchar(50) COLLATE utf8_unicode_ci DEFAULT NULL, | ||
| `linkUri` text COLLATE utf8_unicode_ci NOT NULL, |
There was a problem hiding this comment.
how about linkOrder so they can be sequenced.
Closed
crossan007
reviewed
Mar 5, 2018
| @@ -25,7 +25,7 @@ private static function renderMenuItem(MenuItem $menuItem) | |||
| { | |||
| ?> | |||
| <li> | |||
| <a href="<?= $menuItem->getURI() ?>"> | |||
| <a href="<?= $menuItem->getURI() ?>" <?= $menuItem->isExternal() ? "target='_blank'" : "" ?>> | |||
|
this looks good - merge when you're happy with it. Still need a way to create links. |
crossan007
approved these changes
Mar 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Screenshots (if appropriate)
What Issues does it Close?
Closes #2028
Any background context you want to provide?
Some users wants external links built into the CRM.
Where should the reviewer start?
How should this be manually tested?