Update 3.5.0 #637
Merged
Update 3.5.0 #637
+215
−123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Prepare for next release * Update workflows and readme to mirror latest changes
fix the typo
* Fix setting request body plain text in transaction * Add test for plain text request body
MiSikora
approved these changes
Jun 26, 2021
library/build.gradle
Outdated
| @@ -23,11 +23,16 @@ android { | |||
|
|
|||
| buildFeatures { | |||
| viewBinding = true | |||
| buildConfig = false | |||
There was a problem hiding this comment.
This is in theory a breaking change but I think we can make it slide. I don't suppose anyone uses BuildConfig.
There was a problem hiding this comment.
Good catch. I would like to play safe and be sure that we don't introduce anything breaking for 3.x users, so reverted this change.
vbuberen
commented
Jun 27, 2021
| @@ -95,6 +95,10 @@ afterEvaluate { | |||
| name = 'Olivier Perez' | |||
| email = 'olivier@olivierperez.fr' | |||
| } | |||
| developer { | |||
There was a problem hiding this comment.
@MiSikora Found out that we had you missing for quite some time here in POM. Decided to fix it here. Will do a PR for develop as well later.
Let me know if this data is fine (took it from one of your repos 😄 ) and if you would like to add your email as well here.
There was a problem hiding this comment.
Yup, looks good. Skipping email is fine :).
Bumps `kotlinVersion` from 1.5.10 to 1.5.20. Updates `kotlin-gradle-plugin` from 1.5.10 to 1.5.20 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/v1.5.20/ChangeLog.md) - [Commits](JetBrains/kotlin@v1.5.10...v1.5.20) Updates `kotlin-stdlib` from 1.5.10 to 1.5.20 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/v1.5.20/ChangeLog.md) - [Commits](JetBrains/kotlin@v1.5.10...v1.5.20) --- updated-dependencies: - dependency-name: org.jetbrains.kotlin:kotlin-gradle-plugin dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.jetbrains.kotlin:kotlin-stdlib dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Context
This PR is a set of changes required to release a new version of Chucker with support Android 12.
It has not all changes from
develop, but all non-breaking ones and changes required to support Android 12.📝 Changes
🚫 Breaking
Nothing breaking expected as I tried to take only parts we need.
🛠️ How to test
No special testing required. Tried to run both on an emulator with API 19 and on one with Android S
⏱️ Next steps
I will create a follow up PRs with updates to changelogs and readme files.