Add missing fix to changelog #546
Merged
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cortinico
approved these changes
Jan 31, 2021
|
As a note for the future, we could look into setting up https://danger.systems/kotlin/ to fail PR checks if the changelog file was not updated 🤔 |
|
Do you mean to run it only as a warning and not something that fails CI? IMO public changelog should be updated only if there are changes affecting users. If Danger requires updates to changelog with every PR I think it would be kind of counterproductive as git log is better suited for this job. |
AFAIK it's customisable (as a warn or error) |
|
Yes, it should be. I used Danger in couple of projects and I really like it. Just wanted to suggest that if we integrate it, then changelog check shouldn't result in an error. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Context
A bug fix wasn't mentioned in the changelog.
📝 Changes
I updated the changelog.
📎 Related PR
#538
🚫 Breaking
No.