Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test demonstrating #422 #423

Closed
wants to merge 1 commit into from

Conversation

koral--
Copy link
Contributor

@koral-- koral-- commented Aug 13, 2020

PR only for bug #422 reproduction purposes. Not for direct merging.

@MiSikora
Copy link
Contributor

It fails for me locally, but I'm confused. Shouldn't this test fail the CI?

@koral--
Copy link
Contributor Author

koral-- commented Aug 13, 2020

I expect it to fail on CI. I guess that something is misconfigured on GitHub Actions 🤔
test task is invoked but I'm not sure if unit tests are actually performed. https://github.com/ChuckerTeam/chucker/pull/423/checks?check_run_id=980944852

@MiSikora
Copy link
Contributor

Tests seem to run correctly here https://github.com/ChuckerTeam/chucker/pull/424/checks?check_run_id=981509232#step:4:246. Not sure what is going on. Do you test locally on Linux or macOS?

@koral--
Copy link
Contributor Author

koral-- commented Aug 13, 2020

On macOS only.

@vbuberen
Copy link
Collaborator

Just 2 weeks ago I had sort of similar strange issue with Github Actions on another project. Actions just tried to build project without latest commit and I had to do some additional commit to trigger freshly updated build. Happed on a few branches.

@vbuberen
Copy link
Collaborator

/rebase

@vbuberen
Copy link
Collaborator

vbuberen commented Aug 14, 2020

Trying to make Actions show logs to see info about added test.

UPD: Yeah, missed the fact that this test isn't in Chucker repo, so rebase action has no permission to do automatic rebase.

@MiSikora MiSikora mentioned this pull request Aug 17, 2020
@ghost ghost added the Pending PR The resolution for the issue is in PR label Aug 17, 2020
@cortinico
Copy link
Member

I've cherry-picked your commit on a separate branch on top of develop here: https://github.com/ChuckerTeam/chucker/compare/nc/test-run-for-433

The CI actually fails: https://github.com/ChuckerTeam/chucker/runs/1016449784?check_suite_focus=true
So the issue seems to be related to #435.

Please rebase and the status should be red 👍

@koral--
Copy link
Contributor Author

koral-- commented Aug 23, 2020

Indeed now it fails.
This Issue is addressed in #427 so it seems that this PR can be closed.

@koral-- koral-- closed this Aug 23, 2020
@ghost ghost removed the Pending PR The resolution for the issue is in PR label Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants