Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote classPath to deal with spaces in workspaceRootPath #143

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Quote classPath to deal with spaces in workspaceRootPath #143

merged 1 commit into from
Sep 8, 2023

Conversation

adangel
Copy link
Collaborator

@adangel adangel commented Sep 7, 2023

Fixes #139

@adangel adangel added this to the 0.6.1 milestone Sep 7, 2023
adangel
adangel commented Sep 7, 2023
View reviewed changes
src/lib/apexPmd.ts
let env : NodeJS.ProcessEnv = {...process.env};
env["CLASSPATH"] = classPath;
let env : NodeJS.ProcessEnv = {};
env["CLASSPATH"] = `"${classPath}"`;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the actual fix.
I've changed the log output as well to see more info in case there are further problems.

@ChuckJonas
Copy link
Owner

Looks good to me. After you merge everything in milestone 6.1, ping me and I can pull & publish.

@adangel adangel merged commit 65285f0 into ChuckJonas:master Sep 8, 2023
adangel added a commit that referenced this pull request Sep 8, 2023
@adangel
Merge pull request #143 from adangel:issue-139-quote-classpath
7c3e317 
Quote classPath to deal with spaces in workspaceRootPath
@adangel
Copy link
Collaborator Author

adangel commented Sep 8, 2023

Looks good to me. After you merge everything in milestone 6.1, ping me and I can pull & publish.

@ChuckJonas I've made the release now on github using the tag v0.6.1. You can either rebuilt it from the tag or just use the release artifact from https://github.com/ChuckJonas/vscode-apex-pmd/releases/tag/v0.6.1 (I've downloaded the vsix from the actions workflow and reuploaded it to the release).

@adangel adangel deleted the issue-139-quote-classpath branch September 8, 2023 14:21
@adangel
Copy link
Collaborator Author

adangel commented Sep 8, 2023

@ChuckJonas If you want, you can also add me to your publisher account, then I can publish the new extension myself. My user id is: 0d07caf5-3ed2-6cac-a224-0834485c7cc9.

@ChuckJonas
Copy link
Owner

@adangel done.

let'er rip!

@adangel
Copy link
Collaborator Author

adangel commented Sep 8, 2023

@ChuckJonas Thanks! It worked - 0.6.1 is now available via the marketplace 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.1
Development

Successfully merging this pull request may close these issues.

Error executing PMD when project folder uses spaces
2 participants
@adangel @ChuckJonas