Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue device connection with empty/null objectName prop #304

Merged

Conversation

gnmerritt
Copy link
Contributor

We were missing a whole bunch of devices at a site, turns out a number of the controllers there don't reliably report objectName. This fixes the connect logic to continue regardless, which allows us to pull the point list for devices with no name.

@gnmerritt
Copy link
Contributor Author

Also added a fix to stop a ValueError when presentValue comes back as an empty string. This was stopping point discovery for us in some cases too

@ChristianTremblay
Copy link
Owner

Clearly you've got some very ackward devices...
It won't create issues on good devices so let's merge

Thanks @gnmerritt

@ChristianTremblay ChristianTremblay merged commit e5e3005 into ChristianTremblay:develop Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants