Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release lock only once per thread #23

Merged
merged 1 commit into from
Nov 10, 2019

Conversation

cybe
Copy link
Contributor

@cybe cybe commented Nov 9, 2019

Fixes #13 by making sure to release locks only once per thread. The changes were tested successfully over a couple of weeks in combination with mithermometer and miflora.

@coveralls
Copy link

coveralls commented Nov 9, 2019

Pull Request Test Coverage Report for Build 116

  • 4 of 5 (80.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 97.285%

Changes Missing Coverage Covered Lines Changed/Added Lines %
btlewrap/base.py 4 5 80.0%
Totals Coverage Status
Change from base Build 114: 0.04%
Covered Lines: 860
Relevant Lines: 884

💛 - Coveralls

@ChristianKuehnel ChristianKuehnel merged commit ed5becc into ChristianKuehnel:master Nov 10, 2019
@ChristianKuehnel
Copy link
Owner

Thx!

@cybe cybe deleted the lockingPR branch November 11, 2019 06:26
@cybe
Copy link
Contributor Author

cybe commented Nov 11, 2019

Thanks! Would you mind releasing this as 0.0.9, so I can prepare PRs on dependent projects? No hurry though :)

By the way: pypi shows 0.0.8 as the current version. But this master branch is only at 0.0.8-dev.

@ChristianKuehnel
Copy link
Owner

Thx again for your contribution. New release is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RuntimeError: release unlocked lock
3 participants