Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension tries to autocomplete when cursor is between import and from #13

Closed
kasperekt opened this issue Sep 27, 2016 · 1 comment
Closed

Comments

@kasperekt
Copy link
Contributor

There should be no suggestions when cursor is between import and from keywords.
Right now extension starts to show npm packages names when cursor is in this position:

import React, {PropTypes, Co|} from 'react';
                            ^

It should only give suggestions when cursor is inside import string:

import React, {PropTypes, Component} from 'rea|';
                                              ^

It looks like this in real life:
example_bug

I could take care of this next week. For now, I don't have much time.

@MichalLytek
Copy link

I have the same problem, when I use destructing import (import { ClassName } from "./my-class-file").
It's annoying because I got VS Code intellisense about exported member to choose mixed with npm intellisense.

kasperekt added a commit to kasperekt/NpmIntellisense that referenced this issue Oct 8, 2016
Fixes ChristianKohler#13. Autocomplete only after from keyword if using ES6 syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants