Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logs and few fixes #3

Merged
merged 5 commits into from
Jun 25, 2024

Conversation

ChristianGabs
Copy link
Owner

@ChristianGabs ChristianGabs commented Jun 23, 2024

Due some investigation, I've notice it's hard to trace in case your IPN Secret is not valid

  • Provide logs in FOSS in case IPN Secret or is incomming webhook request valid
  • Do more research on event type as by default is set only for InvoicePaymentSettled
  • Investigate partial payment as the last testing the invoice is marking as paid.

@ChristianGabs ChristianGabs linked an issue Jun 23, 2024 that may be closed by this pull request
3 tasks
@ChristianGabs ChristianGabs self-assigned this Jun 23, 2024
…apture only the payment but not the invoice as well.
@ChristianGabs
Copy link
Owner Author

ChristianGabs commented Jun 24, 2024

  • InvoiceReceivedPayment: Payment has been seen in the mempool (unconfirmed)
  • InvoicePaymentSettled: Payment has been confirmed on the blockchain
  • InvoiceSettled: Payment is confirmed on the blockchain.

Move the event type to InvoiceSettled, as that will cover cases where partial payments are made due to fees or manual sent, avoiding any issues and also preventing the invoice from being marked as paid.

@ChristianGabs ChristianGabs marked this pull request as ready for review June 25, 2024 17:41
@ChristianGabs ChristianGabs marked this pull request as draft June 25, 2024 17:49
@ChristianGabs ChristianGabs marked this pull request as ready for review June 25, 2024 17:50
@ChristianGabs ChristianGabs merged commit c074e78 into main Jun 25, 2024
@ChristianGabs ChristianGabs deleted the 2-add-logs-to-be-easy-to-trace-callbacks branch June 25, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add logs to be easy to trace callbacks
1 participant