-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the option to change the UI Theme at runtime #2693
Add the option to change the UI Theme at runtime #2693
Conversation
… ChrisTitusTech-main
…stead of resouces
… ChrisTitusTech-main
Hey Marterich |
I've reimplemented the Theme changes you referenced. |
Type of Change
Description
This PR Adds a new Button to Switch from Light to Dark Mode at runtime.
Winutil will persist the setting across reboots and start with the latest theme used.
Impact
As this PR completely overhauls how the Properties for the UI Elements are stored (now as Resource Objects), it touches almost EVERY UI Element. Still, IMHO this creates a good foundation to unify how we handle properties like colors in the future in a scalable, maintainable way.
Testing
Tested on Win11
Please test thoroughly as this revamps many of the UI internals and might have missed something.
Issue related to PR
Additional Information
I simplified the themes (completely removed the pulsing) and decided to keep only a Light and a Dark Theme. This can be easily extended in the future, for example, to allow more than 2 Themes or even Custom Themes that the user can modify.