Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Transcript #2620

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Improve Transcript #2620

merged 3 commits into from
Aug 28, 2024

Conversation

MyDrift-user
Copy link
Contributor

Pull Request

Improve Transcript

Type of Change

  • Refactoring

Description

Improving log by seperating them by date, I think that helps when having to look at them and running winutil a lot.

Testing

  • works, took inspiration from my old script

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@MyDrift-user MyDrift-user marked this pull request as ready for review August 24, 2024 19:56
@ChrisTitusTech ChrisTitusTech force-pushed the main branch 2 times, most recently from 7805fe4 to cfb9edb Compare August 26, 2024 22:01
og-mrk
og-mrk reviewed Aug 27, 2024
View reviewed changes
scripts/start.ps1 Outdated Show resolved Hide resolved
og-mrk
og-mrk approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@og-mrk og-mrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a much appreciated (yet, simple) patch, thanks @MyDrift-user 😄

@ChrisTitusTech ChrisTitusTech merged commit 6a99be9 into ChrisTitusTech:main Aug 28, 2024
1 check passed
@ChrisTitusTech ChrisTitusTech added the skip-changelog Skip Change Logs label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@og-mrk og-mrk og-mrk approved these changes

@ChrisTitusTech ChrisTitusTech ChrisTitusTech approved these changes

Assignees
No one assigned
Labels
skip-changelog Skip Change Logs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MyDrift-user @ChrisTitusTech @og-mrk