Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dialogbox theme #2490

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

MyDrift-user
Copy link
Contributor

Pull Request

Fix Dialogbox Theme

Type of Change

  • UI/UX improvement

Description

Dialogbox ("about" window) uses a custom theme and not the one the winutil gui uses, meaning light mode is not supported.
I changed it to use the existing theme, meaning it looks more like the gui and themes right in light mode.

Before:
image
image

After:
image
image

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

Copy link
Contributor

@Real-MullaC Real-MullaC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this PR as it makes the UI look more Modern for the About Section. Will this also apply to the Sponsors Section?

@MyDrift-user
Copy link
Contributor Author

Love this PR as it makes the UI look more Modern for the About Section. Will this also apply to the Sponsors Section?

Thanks @Real-MullaC and yes, this applies to every "popup window" created using the custom dialog function. (about & sponsor at the time)

Copy link
Owner

@ChrisTitusTech ChrisTitusTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing

@ChrisTitusTech ChrisTitusTech merged commit 9284741 into ChrisTitusTech:main Aug 6, 2024
@ChrisTitusTech ChrisTitusTech added the skip-changelog Skip Change Logs label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skip Change Logs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants