Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PowerShell logo in README.md #2457

Closed
wants to merge 1 commit into from
Closed

add PowerShell logo in README.md #2457

wants to merge 1 commit into from

Conversation

mntrngh
Copy link

@mntrngh mntrngh commented Jul 26, 2024

Pull Request

Title

Add PowerShell logo in README.md

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

Again, not sure what's the best way to do it but I think that we need to clarify that you can run the script using "Windows PowerShell" and not only "PowerShell". Maybe this particular change in this commit don't do enough or maybe we should do it another way.

PR comment related to this issue

I was addressing it in: #2455

Checklist

  • [ x My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@mntrngh mntrngh requested a review from ChrisTitusTech as a code owner July 26, 2024 00:16
Copy link
Contributor

@og-mrk og-mrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do like this change, but if possible to align it via a Gride, or by putting it as last badge in this badges list.

Screenshots

image
image

@ChrisTitusTech
Copy link
Owner

I'm a bit minimal and don't like the added png at the top of the readme.

@mntrngh mntrngh deleted the patch-1 branch July 31, 2024 05:26
@ChrisTitusTech ChrisTitusTech added the skip-changelog Skip Change Logs label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skip Change Logs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants