-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates docs to try allow better customising and removes announcment banner. #2448
Updates docs to try allow better customising and removes announcment banner. #2448
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Real-MullaC This'll be fixed in PR #2416
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Real-MullaC I still think that the documentation isn't finished yet, needs more polishing & some sections to be added to it, you can change the styling & wording to not that the Documentation isn't finished but most common sections should be stable/reliable enough to use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check PR #2427
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check PR #2427
Reviewed that PR a few days ago, and still think there's room for improvement on the documentation, at the event that you think the documentation won't need to change in the next 2 years (from a UX & General Content Layout), then I'd say the docs are stable, which means we won't need this warning.
Again, if you think this warning is annoying (because of its coloring, font size, or position), then you can change the in-line CSS styling.
@Real-MullaC couple merge conflicts to work through after merging the #2427 |
Pull Request
Title
Updates docs to try allow better customising and removes announcment banner.
Type of Change
Description
Updates docs to try allow better customising and removes announcment banner. PR #2427 needs pushing before this PR.
Testing
I have tested this locally and banner is removed but custom css still is not.
Impact
Helps people customize the docs better.
Issue related to PR
[What issue/discussion is related to this PR (if any)]
Additional Information
No
Checklist