Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename some Preferences #2421

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

MyDrift-user
Copy link
Contributor

Pull Request

Renamed some Preferences to be shorter & cleaner

Type of Change

  • UI/UX improvement

Description

Removed Enable/Show text on some preferences depending on how easy they are to understand.
Everyone knows that a filled out toggle is enabled, and if not it is still written in the description

Testing

tested, looks good

Preview

image

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

Copy link
Contributor

@og-mrk og-mrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My Descriptive Titles for Toggles.. but I do like the removal of these, not gonna lie 😂
Good Commits @MyDrift-user

Copy link
Owner

@ChrisTitusTech ChrisTitusTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, MUCH CLEARER!

@ChrisTitusTech ChrisTitusTech merged commit 8beca95 into ChrisTitusTech:main Jul 25, 2024
@MyDrift-user MyDrift-user deleted the preferencescleanup branch July 28, 2024 14:55
@ChrisTitusTech ChrisTitusTech added the skip-changelog Skip Change Logs label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skip Change Logs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants