Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added get installed check for classic right click menu tweak #2231

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

btstromberg
Copy link
Contributor

@btstromberg btstromberg commented Jun 30, 2024

Checks the existence of the registry keys default string value to determine status. Also has to change the if statement in Invoke-WinUtilCurrentSystem.ps1 to be false when the registry key does not exist. Otherwise the box will always get checked no matter what.

I am very new to Github and this is my first ever pull request. Let me know if I did something incorrectly.

EDIT: I meant to write "right click menu tweak", not start menu. I don't know how to change it now..

@MyDrift-user
Copy link
Contributor

MyDrift-user commented Jun 30, 2024

Hello @btstromberg, congratultions to your first PR

If you want to change the Name of the Pull Request, you can do that by pressing edit on the top next to the Title:

image

The compiled WinUtil.ps1 file should not be commited, in Github Desktop for example you can discard changed to a specific file with a right click on it and selecting discard. That usually is the cause of Merge conflicts, with which the PR can't automatically be merged.

@btstromberg btstromberg changed the title Added get installed check for classic start menu tweak Added get installed check for classic right click menu tweak Jun 30, 2024
@btstromberg
Copy link
Contributor Author

Thanks. Yeah I saw that the WinUtil.ps1 was commited too, I did not mean to do that. What should I do now that I have already commited it?

@MyDrift-user
Copy link
Contributor

MyDrift-user commented Jun 30, 2024

No worries, It can happen.
I am no expert myself but what I would do is downloading the winutil.ps1 from Chris's repo folder and replace your compiled one in the fork with the "old" one.

@ChrisTitusTech ChrisTitusTech merged commit 7dcd0ed into ChrisTitusTech:main Jul 8, 2024
@ChrisTitusTech ChrisTitusTech added the skip-changelog Skip Change Logs label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skip Change Logs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants