Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use leaflet-distortable-image 0.3.0 via NPM #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jywarren
Copy link

@jywarren jywarren commented Feb 25, 2019

@jywarren jywarren changed the title leaflet-distortable-image-0.3.0 use leaflet-distortable-image 0.3.0 via NPM Feb 25, 2019
@@ -1,7 +1,7 @@
import { MapLayer, withLeaflet } from 'react-leaflet';
import PropTypes from 'prop-types';

import './lib/leaflet-distortableimage';
import './node_modules/leaflet-distortable-image/dist/Leaflet.DistortableImage.js';
import './lib/leaflet-path-transform';
import L from 'leaflet';

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So in Props below, I think we would need to follow guidance in publiclab/Leaflet.DistortableImage#132 and add suppressToolbar: true, but I'm not 100% sure how this gets fed into the multiple instances below of new L.DistortableImageOverlay(props.url, this.getOptions(props)); - i see three in this file, for example:

https://github.com/ChrisLowe-Takor/react-leaflet-distortable-imageoverlay/pull/4/files#diff-4d50686480707aba7ccb6620f6e54d9aR19

@@ -1,7 +1,7 @@
import { MapLayer, withLeaflet } from 'react-leaflet';
import PropTypes from 'prop-types';

import './lib/leaflet-distortableimage';
import './node_modules/leaflet-distortable-image/dist/Leaflet.DistortableImage.js';
import './lib/leaflet-path-transform';
import L from 'leaflet';

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't get this compiling but I'm certain it's a problem with the way I've configured the project with create-react-library. Thanks for the upstream changes. I'll look at getting this in soon as I can.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this was just my guess... that's where npm would install the lib but I haven't tried running npm install to see if it actually shows up there. If you share your error maybe I can help debug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants