Alternative visualization for pulse #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this should be an optional behavior. Introduce this as an alternative function, and use it from the call site on the basis of the option setting. Otherwise, I think it looks good. |
* Added functionality for visualizer component to receive non exclusive mouse input (only a few things were missing in the component manager) * Implemented switching of visualization mode when clicked (left mouse button)
micheldebree
added a commit
that referenced
this pull request
Sep 27, 2023
#167) * [major] Implemented real time SID registers visualization (pulse and filter values). Additionally: * Made it possible for components to not receive focus * Added user colors for visualization bars * Updated default color scheme * [minor] Adding visualization of pulse and filter [minor] Adding first iteration of highlighting the sequence index being selected in the song overview * Adapted colorschemes to new visualizers (#102) * Updated README (#102) * [trivial] Fixed up the tab indentation from 2 to 4 (both, so that converting back to using tabs actually works when using the clang formatter) * [minor] Adding a vertical line over the 3 bars that indicate the pulse state output to SID. The vertical line indicates the 50% pulse width mark. * Alternative visualization for pulse (#169) * Alternative visualization for pulse * Made visualization style for pulse configurable (#102) * Formatting * Formatting * Formatting * Formatting * Added config option to README * [minor] Pulse filter visualizer extensions: * Added functionality for visualizer component to receive non exclusive mouse input (only a few things were missing in the component manager) * Implemented switching of visualization mode when clicked (left mouse button) --------- Co-authored-by: rawpowerlaxity <thomas@rawpowergames.com> * Mute pulse visualizer when track is muted * Used same enabled/muted colors as the track * If no enabled channels use filter, mute filter meter * Revert "If no enabled channels use filter, mute filter meter" This reverts commit 86b1322. * Made bar with divider pulse width bar It already had pulse width specifics in the implementation, so I made that clearer * [minor] Changed color settings propery names for the pulse and filter visualization from Color.StateBar.xxx to Color.Visualizer.xxx Also added specific color for the pulse bar separator line NOTE: Added a default DarkestGrey color the fall back color definitions * Update all color schemes for the new visualizer --------- Co-authored-by: thereallaxity <thomas.egeskov.petersen@gmail.com> Co-authored-by: rawpowerlaxity <thomas@rawpowergames.com> Co-authored-by: Jens-Christian Huus <chordian@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative visualization for pulse, where the width of the bar reflects the width of the (smallest) pulse.