Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve bug 473 #739

Merged
merged 7 commits into from
Nov 7, 2019
Merged

Resolve bug 473 #739

merged 7 commits into from
Nov 7, 2019

Conversation

jshjohnson
Copy link
Collaborator

Description

Applies @markjoeljimenez's fix (#583) over master with some tweaks

Screenshots (if appropriate)

Types of changes

  • Chore (tooling change or documentation change)
  • Refactor (non-breaking change which maintains existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jshjohnson jshjohnson added the bugfix Pull request that fixes an existing bug label Nov 4, 2019
@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #739 into master will decrease coverage by 0.02%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #739      +/-   ##
==========================================
- Coverage   66.64%   66.61%   -0.03%     
==========================================
  Files          22       22              
  Lines        1307     1309       +2     
==========================================
+ Hits          871      872       +1     
- Misses        436      437       +1
Impacted Files Coverage Δ
src/scripts/choices.js 54.39% <25%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81c44ba...e1aaaf1. Read the comment docs.

@jshjohnson jshjohnson closed this Nov 5, 2019
@jshjohnson jshjohnson reopened this Nov 5, 2019
@jshjohnson jshjohnson mentioned this pull request Nov 5, 2019
8 tasks
@jshjohnson jshjohnson merged commit b5b593a into master Nov 7, 2019
@jshjohnson jshjohnson deleted the resolve-bug-473 branch November 7, 2019 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants