-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAJOR] Remove .ajax
and allow async function for .setChoices
#701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just waiting for #700 to merge and rebase to remove that's code from here. |
This also closes #604 |
tinovyatkin
changed the title
[MAJOR] Remove
[MAJOR] Remove Oct 27, 2019
.ajax
, add .fetchChoices
.ajax
, add allow functions to .setChoices
tinovyatkin
changed the title
[MAJOR] Remove
[MAJOR] Remove Oct 28, 2019
.ajax
, add allow functions to .setChoices
.ajax
and allow callback to .setChoices
tinovyatkin
changed the title
[MAJOR] Remove
[MAJOR] Remove Oct 28, 2019
.ajax
and allow callback to .setChoices
.ajax
and allow async function for .setChoices
Also closes #626 |
jshjohnson
approved these changes
Oct 29, 2019
This is much cleaner - thanks! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
.ajax
method and introduces similar functionality by extending.setChoices
Description
Remove
.ajax
method due to bad name (it's not immediately clear what it does, and soon probably nobody will understand acronym, as I didn't remembered that AJAX stands for Asynchronous Javascript And XML 😳) and outdated functionality concept.Introduces abiltiy to pass a callback or async function as first parameter to
.setChoices
to provide similar functionality for today'Promise
world.Motivation and Context
Almost all modern day fetching APIs are Promises based (all your examples except one are), while we are providing callback 😏 way to do that.
This also removes
fetchFromObject
helper function and delegates to consumer to do complete data transformation (fetchFromObject
handles just one use case, without arrays, etc, and complete solution will require to introduce a huge dependency - so, it's better to let a consumer do whole transformation).NOTE: This PR is not adding direct dependency on
Promise
implementation in Browser, so, not addingPromise
to required polyfills.How Has This Been Tested?
Refactored existing test and introduced new one.
Types of changes
Checklist: