This repository was archived by the owner on Jun 28, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
ENH: Enable conversion of non-Python notebooks to downloadable scripts #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 similar comments
Let me know, when you are done with it and need any review or work from my side. Thank you for the contribution 😃 In any case, I would add a non-Python notebook here and a test for it |
effigies
commented
May 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ready for review. It works for me, and doesn't produce any obvious errors in the test output.
Oh, sorry, just read:
Sounds good. |
71fef68
to
acb0258
Compare
Awesome! Thanks a lot @effigies for your input! 👍 I added the bash_kernel package to be installed on RTD (otherwise building the docs will fail) and I added some tests for your bash example. When the tests pass, I will merge this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may not be properly guarded; I don't have a lot of Notebooks to test against. Kind of hoping your tests will catch dependency on non-required metadata.
Closes #4.