Skip to content
This repository was archived by the owner on Jun 28, 2021. It is now read-only.

ENH: Enable conversion of non-Python notebooks to downloadable scripts #6

Merged
merged 6 commits into from
May 14, 2019

Conversation

effigies
Copy link
Contributor

This may not be properly guarded; I don't have a lot of Notebooks to test against. Kind of hoping your tests will catch dependency on non-required metadata.

Closes #4.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 87.5% when pulling c25f317 on effigies:fix/drop_python_file into 3a87e26 on Chilipp:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 87.5% when pulling c25f317 on effigies:fix/drop_python_file into 3a87e26 on Chilipp:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 87.5% when pulling c25f317 on effigies:fix/drop_python_file into 3a87e26 on Chilipp:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 87.5% when pulling c25f317 on effigies:fix/drop_python_file into 3a87e26 on Chilipp:master.

@Chilipp
Copy link
Owner

Chilipp commented May 14, 2019

Coverage decreased (-0.09%) to 87.5% when pulling c25f317 on effigies:fix/drop_python_file into 3a87e26 on Chilipp:master.

Sorry, I increased the threshold for coverage checks. You can ignore this failure

@Chilipp
Copy link
Owner

Chilipp commented May 14, 2019

Let me know, when you are done with it and need any review or work from my side. Thank you for the contribution 😃

In any case, I would add a non-Python notebook here and a test for it

Copy link
Contributor Author

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready for review. It works for me, and doesn't produce any obvious errors in the test output.

@effigies
Copy link
Contributor Author

Oh, sorry, just read:

In any case, I would add a non-Python notebook here and a test for it.

Sounds good.

@effigies
Copy link
Contributor Author

Okay, this is ready for review. Docs build locally, if not very prettily:

Screen Shot 2019-05-14 at 11 23 11

@effigies effigies force-pushed the fix/drop_python_file branch from 71fef68 to acb0258 Compare May 14, 2019 15:29
@Chilipp
Copy link
Owner

Chilipp commented May 14, 2019

Awesome! Thanks a lot @effigies for your input! 👍 I added the bash_kernel package to be installed on RTD (otherwise building the docs will fail) and I added some tests for your bash example. When the tests pass, I will merge this PR.

@Chilipp Chilipp merged commit 8f20c7b into Chilipp:master May 14, 2019
@effigies effigies deleted the fix/drop_python_file branch May 15, 2019 12:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-Python notebooks produce invalid .py files for download
3 participants