Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [Data Viz] Display Severity and Legend (CAMHI) (M2-7672) #1925

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

sultanofcardio
Copy link
Contributor

@sultanofcardio sultanofcardio commented Sep 20, 2024

  • Tests for the changes have been added

📝 Description

🔗 Jira Ticket M2-7672

Note

This feature is behind the flag enableCahmiSubscaleScoring

This PR updates the dataviz summary page with the following new visualizations of subscale severity:

  • The style of the points on the line chart have been updated to match the severity designs
  • The severity of a point has been added to the tooltip for each point on the line chart
  • The severity has been added to the additional information block of the expandable subscale card when the data is displayed using a line chart
  • A legend has been added below the line chart explaining the severity point styles

📸 Screenshots

image image image

🪤 Peer Testing

TBD

✏️ Notes

The tooltips as designed are missing some elements from the existing tooltips which I think are necessary. I’ve decided to combine them in a way that I think keeps the spirit of the design

Design vs implementation:

image


Unrelated lines on the chart can look like they’re connected to each other, but they’re just overlapping. This means that sometimes we won’t be able to easily tell the severity of a point without hovering


The commit d2ebaa8 is present on this branch until #1922 is merged to develop. This is to avoid conflicts since I'm touching some of the same components

@sultanofcardio sultanofcardio self-assigned this Sep 20, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1925.d19gtpld8yi51u.amplifyapp.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants