Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify op decoding #402

Merged
merged 4 commits into from
May 7, 2024
Merged

Simplify op decoding #402

merged 4 commits into from
May 7, 2024

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented May 7, 2024 •
edited
Loading

This, especially, makes it simpler to add another extension operator set. It won't require nesting them.

@arvidn arvidn force-pushed the simplify-op-decoding branch from 37d2347 to 11bd73e Compare May 7, 2024 10:51
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented May 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8986554835

Details

  • 10 of 26 (38.46%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 94.072%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/chia_dialect.rs 9 25 36.0%
Totals Coverage Status
Change from base Build 8912264999: 0.1%
Covered Lines: 5792
Relevant Lines: 6157
💛 - Coveralls

@arvidn arvidn force-pushed the simplify-op-decoding branch from 11bd73e to 5d12a45 Compare May 7, 2024 13:06
@arvidn arvidn requested a review from Rigidity May 7, 2024 13:08
Rigidity
Rigidity approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@Rigidity Rigidity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@arvidn arvidn marked this pull request as ready for review May 7, 2024 13:52
@arvidn arvidn merged commit 9ad7700 into main May 7, 2024
27 checks passed
@arvidn arvidn deleted the simplify-op-decoding branch May 7, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rigidity Rigidity Rigidity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arvidn @Rigidity