port all unit tests from clvm to clvm_rs #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidn
commented
Mar 4, 2022
| match s.split_once(" ") { | ||
| Some((first, rest)) => (first.trim(), rest.trim()), | ||
| None => (s.trim(), ""), | ||
| if s.starts_with("\"") { |
There was a problem hiding this comment.
this was made a little bit more sophisticated to support quoted atoms with spaces inside the quotes.
This comment was marked as outdated.
This comment was marked as outdated.
|
The new tests with hex source are very unreadable. How did you create them? I'd really recommend checking in the tools you used to create them, or better yet, keeping the tests in clvm source format so they're not so impenetrable. |
|
I used the |
|
@richardkiss I backed out those |
richardkiss
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These additional test now cover all cases covered by the
clvmtest programs