Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

**/*.lock linguist-generated=false #843

Merged
merged 1 commit into from
Jan 7, 2025
Merged

**/*.lock linguist-generated=false #843

merged 1 commit into from
Jan 7, 2025

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Jan 6, 2025

https://docs.github.com/en/repositories/working-with-files/managing-files/customizing-how-changed-files-appear-on-github

default to showing lock file diffs in pr view. they are defaulted to not showing since people often like to ignore their noise. with granular changes i think it's worth looking over them to make sure there aren't unexpected changes. in the case of merging large branches with too many lock changes to review, go ahead and mark it viewed and github will keep it hidden until it is changed.

like Chia-Network/chia-blockchain#18939

default to showing lock file diffs in pr view.  they are defaulted to not showing since people often like to ignore their noise.  with granular changes i think it's worth looking over them to make sure there aren't unexpected changes.  in the case of merging large branches with too many lock changes to review, go ahead and mark it viewed and github will keep it hidden until it is changed.
@altendky altendky requested review from arvidn and Rigidity January 6, 2025 15:46
Copy link

Pull Request Test Coverage Report for Build 12635585974

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.972%

Totals Coverage Status
Change from base Build 12583890888: 0.0%
Covered Lines: 13349
Relevant Lines: 15897

💛 - Coveralls

@altendky altendky merged commit c3954f8 into main Jan 7, 2025
52 checks passed
@altendky altendky deleted the altendky-patch-7 branch January 7, 2025 17:44
altendky added a commit that referenced this pull request Jan 7, 2025
This reverts commit c3954f8, reversing
changes made to 3f7ce68.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants