Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pyo3 to 0.23.3 #842

Merged
merged 3 commits into from
Jan 6, 2025
Merged

update pyo3 to 0.23.3 #842

merged 3 commits into from
Jan 6, 2025

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Jan 3, 2025

Draft For:

  • review TODOs
  • review .unwrap()
  • should there be more .unbind()?
  • discuss smelliness of .into_any() and type Target = PyAny;

Copy link

coveralls-official bot commented Jan 3, 2025

Pull Request Test Coverage Report for Build 12612897613

Details

  • 77 of 111 (69.37%) changed or added relevant lines in 18 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 83.93%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/chia-protocol/src/coin_spend.rs 0 1 0.0%
wheel/src/api.rs 3 5 60.0%
crates/chia-bls/src/bls_cache.rs 7 10 70.0%
crates/chia-protocol/src/bytes.rs 8 12 66.67%
crates/chia-protocol/src/block_record.rs 0 6 0.0%
crates/chia-protocol/src/chia_protocol.rs 0 6 0.0%
crates/chia-protocol/src/wallet_protocol.rs 0 6 0.0%
crates/chia-traits/src/int.rs 2 8 25.0%
Files with Coverage Reduction New Missed Lines %
crates/chia-protocol/src/wallet_protocol.rs 2 0.0%
crates/chia-protocol/src/chia_protocol.rs 2 0.0%
Totals Coverage Status
Change from base Build 12583890888: -0.04%
Covered Lines: 13360
Relevant Lines: 15918

💛 - Coveralls

@altendky altendky marked this pull request as ready for review January 6, 2025 15:36
@altendky altendky requested review from arvidn and Rigidity January 6, 2025 15:37
@altendky altendky merged commit ea4928b into main Jan 6, 2025
52 checks passed
@altendky altendky deleted the update_pyo3_0_23_3 branch January 6, 2025 18:57
altendky added a commit that referenced this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants