-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add needed items for sdist #755
Conversation
Pull Request Test Coverage Report for Build 11263879338Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not obvious why chia-client
and chia-ssl
are needed to build the wheel. Is maturin failing to bundle transitive dependencies? I wouldn't expect these to be part of the dependency tree at all though
When maturin builds the sdist, it puts in the tar the |
I see. thanks for the explanation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm for now
Add in some missing bits in wheel/Cargo.toml and some hacks around missing parts in the tar archive
Main items are:
needing to add in
chia-client
andchia-ssl
towheel/Cargo.toml
needing to remove the
../LICENSE
fromwheel/Cargo.toml
- this resulted in the tar not having the LICENSE file but also pip expecting it, so I just removed it for now.I noticed the tar was missing the
src
directory, so I had to manually add in the src directory to the tar archive.This does make a
tar.gz
that does build on my riscv machine and also my mac.