Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert accidental change while fixing clippy warnings #706

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Revert accidental change while fixing clippy warnings #706

merged 1 commit into from
Sep 13, 2024

Conversation

AmineKhaldi
Copy link
Contributor

This is part of PR #703 that got conflicted by PR #705.

@AmineKhaldi AmineKhaldi self-assigned this Sep 9, 2024
@AmineKhaldi AmineKhaldi requested a review from altendky September 9, 2024 15:47
@AmineKhaldi AmineKhaldi marked this pull request as ready for review September 9, 2024 15:47
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Sep 9, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10777747842

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 83.951%
Totals Coverage Status
Change from base Build 10776279583: -0.002%
Covered Lines: 12371
Relevant Lines: 14736
💛 - Coveralls

altendky
altendky previously requested changes Sep 9, 2024
View reviewed changes
crates/chia-consensus/src/spendbundle_conditions.rs Outdated Show resolved Hide resolved
@AmineKhaldi AmineKhaldi force-pushed the revert_change_while_fixing_clippy branch from 5fb1696 to 2ea058d Compare September 9, 2024 16:57
@altendky altendky dismissed their stale review September 9, 2024 17:00

concerns addressed

@AmineKhaldi AmineKhaldi merged commit 76bca31 into Chia-Network:main Sep 13, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rigidity Rigidity Rigidity approved these changes

@arvidn arvidn arvidn approved these changes

@altendky altendky altendky left review comments

Assignees

@AmineKhaldi AmineKhaldi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AmineKhaldi @altendky @arvidn @Rigidity