Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHIA-1171: Make DID recovery list hash optional #667

Merged
merged 1 commit into from
Aug 16, 2024
Merged

CHIA-1171: Make DID recovery list hash optional #667

merged 1 commit into from
Aug 16, 2024

Conversation

Rigidity
Copy link
Contributor

If the recovery list is empty, this saves 32 bytes of space in the puzzle reveal.

@Rigidity Rigidity requested a review from arvidn August 16, 2024 04:56
@Rigidity Rigidity mentioned this pull request Aug 16, 2024
Merged
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 10414872865

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 83.881%
Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/chia-puzzles/src/puzzles/did.rs 2 3 66.67%
Totals Coverage Status
Change from base Build 10408385324: -0.007%
Covered Lines: 12302
Relevant Lines: 14666
💛 - Coveralls

@Rigidity Rigidity changed the title Make DID recovery list hash optional CHIA-1171: Make DID recovery list hash optional Aug 16, 2024
arvidn
arvidn approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the way this is decoded relies in matching the number of items and maybe that a u64 is smaller than a bytes32, right?

@Rigidity
Copy link
Contributor Author

the way this is decoded relies in matching the number of items and maybe that a u64 is smaller than a bytes32, right?

Option is encoded as nil or bytes32 in this case

@Rigidity Rigidity merged commit 9ec89f0 into main Aug 16, 2024
59 checks passed
@Rigidity Rigidity deleted the optional-recovery branch August 16, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rigidity @arvidn