Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable message conditions unconditionally #644

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Aug 6, 2024

remove the flag controlling whether message conditions are enabled or not. Since soft-fork 4 has activated, we can enable them unconditionally.

Copy link

coveralls-official bot commented Aug 6, 2024

Pull Request Test Coverage Report for Build 10298013592

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.009%) to 83.851%

Totals Coverage Status
Change from base Build 10290976970: -0.009%
Covered Lines: 12295
Relevant Lines: 14663

💛 - Coveralls

@arvidn arvidn force-pushed the message-conditions branch 2 times, most recently from 1c29b5d to 209ff19 Compare August 6, 2024 11:20
@arvidn arvidn force-pushed the message-conditions branch from 209ff19 to 4bbdc5c Compare August 8, 2024 07:42
@arvidn arvidn marked this pull request as ready for review August 8, 2024 08:04
@arvidn arvidn requested a review from AmineKhaldi August 8, 2024 08:16
@arvidn arvidn merged commit 3130a0f into main Aug 8, 2024
59 checks passed
@arvidn arvidn deleted the message-conditions branch August 8, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants