CHIA-922: CHIA-938: Add signing and verification methods #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
changed the title
Pull Request Test Coverage Report for Build 9960878291Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Rigidity
changed the title
Rigidity
changed the title
|
Non-blocking comment - can you add some descriptions of what and why for this PR? |
AmineKhaldi
approved these changes
Jul 22, 2024
arvidn
reviewed
Jul 26, 2024
| @@ -242,8 +242,15 @@ impl SecretKey { | |||
| #[classattr] | |||
| pub const PRIVATE_KEY_SIZE: usize = 32; | |||
|
|
|||
| pub fn sign_g2(&self, msg: &[u8]) -> crate::Signature { | |||
| crate::sign(self, msg) | |||
| pub fn sign(&self, msg: &[u8], final_pk: Option<PublicKey>) -> crate::Signature { | |||
There was a problem hiding this comment.
I understand the python interface has this optional public key, but do we ever actually use it? If not, it would be cleaner to just not have it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
G1Element::verifyandSecretKey::signin Python as part of the wallet signer effort.