Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is best reviewed one commit at a time, as the flags are fairly independent.
Now that the hard fork has activated, some feature flags are no longer necessary (as they are always enabled).
ENABLE_SOFTFORK_CONDITION
,AGG_SIG_ARGS
andCOND_ARGS_NIL
- these features are always-on now.The change around
AGG_SIG_ARGS
andCOND_ARGS_NIL
is probably the least obvious. Before the hard fork,AGG_SIG_ME
andAGG_SIG_UNSAFE
required exactly two arguments (as opposed to all other conditions, that allow unknown arguments). WhenAGG_SIG_ARGS
is set (as it is after the hard fork activation), theAGG_SIG_ME
andAGG_SIG_UNSAFE
conditions behave like the others. This is why the special cases can be removed inconditions.rs
, here.