Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use PublicKey in OwnedSpendBundleConditions #495

Merged
merged 1 commit into from
Apr 29, 2024
Merged

use PublicKey in OwnedSpendBundleConditions #495

merged 1 commit into from
Apr 29, 2024

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Apr 29, 2024

make OwnedSpendBundleConditions (and OwnedSpend) expose PublicKey rather than Bytes48 in the agg sig conditions

@arvidn arvidn requested a review from Rigidity April 29, 2024 13:26
@arvidn arvidn force-pushed the public-key-spend-bundle-conditions branch 2 times, most recently from 18c79ec to 038f171 Compare April 29, 2024 13:54
@arvidn arvidn requested a review from matt-o-how April 29, 2024 13:55
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Apr 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8882058293

Details

  • 27 of 30 (90.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 84.832%
Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/chia-consensus/src/gen/owned_conditions.rs 20 21 95.24%
wheel/src/run_generator.rs 6 8 75.0%
Totals Coverage Status
Change from base Build 8881567835: -0.01%
Covered Lines: 11756
Relevant Lines: 13858
💛 - Coveralls

Rigidity
Rigidity previously approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@Rigidity Rigidity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

matt-o-how
matt-o-how previously approved these changes Apr 29, 2024
View reviewed changes
@arvidn arvidn dismissed stale reviews from matt-o-how and Rigidity via 8b52d0a April 29, 2024 16:27
@arvidn arvidn force-pushed the public-key-spend-bundle-conditions branch from 038f171 to 8b52d0a Compare April 29, 2024 16:27
@arvidn arvidn merged commit 023e1cf into main Apr 29, 2024
64 checks passed
@arvidn arvidn deleted the public-key-spend-bundle-conditions branch April 29, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-o-how matt-o-how matt-o-how approved these changes

@Rigidity Rigidity Rigidity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arvidn @Rigidity @matt-o-how