Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use arbitrary feature instead of cfg fuzzing for conditional compilation #494

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

Rigidity
Copy link
Contributor

The benefits are the following:

  • Enables rust-analyzer to enable that code path, allowing for better error reporting instead of being grayed out.
  • Disables the arbitrary dependency in production.
  • Simplifies some code in the fuzz tests.
  • You can use arbitrary in non-fuzz dependents if desired now.

@Rigidity Rigidity requested a review from arvidn April 29, 2024 11:08
Copy link

Pull Request Test Coverage Report for Build 8877886551

Details

  • 1 of 9 (11.11%) changed or added relevant lines in 5 files are covered.
  • 31 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.2%) to 84.867%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/chia-wallet/src/puzzles/nft.rs 0 1 0.0%
crates/chia-protocol/src/bytes.rs 0 2 0.0%
crates/chia-protocol/src/chia_protocol.rs 0 2 0.0%
crates/chia-wallet/src/proof.rs 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
crates/chia-bls/src/signature.rs 4 95.97%
crates/chia-bls/src/public_key.rs 4 92.94%
crates/chia-bls/src/secret_key.rs 5 94.74%
crates/chia-protocol/src/program.rs 18 68.56%
Totals Coverage Status
Change from base Build 8847398065: -0.2%
Covered Lines: 11766
Relevant Lines: 13864

💛 - Coveralls

Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at some point we should document the features we have

@Rigidity Rigidity merged commit 6da9f22 into main Apr 29, 2024
64 checks passed
@Rigidity Rigidity deleted the arbitrary-feature branch April 29, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants