Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify lineage proof and remove chia-consensus singleton types #492

Merged
merged 6 commits into from
Apr 29, 2024

Conversation

Rigidity
Copy link
Contributor

There were duplicated types between chia-wallet and chia-consensus, so this makes chia-consensus use chia-wallet's types instead and simplifies the API for lineage proofs.

@Rigidity Rigidity requested a review from arvidn April 27, 2024 13:16
Copy link

coveralls-official bot commented Apr 27, 2024

Pull Request Test Coverage Report for Build 8877255872

Details

  • 24 of 29 (82.76%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 85.076%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/chia-consensus/src/fast_forward.rs 24 29 82.76%
Totals Coverage Status
Change from base Build 8847398065: -0.03%
Covered Lines: 11766
Relevant Lines: 13830

💛 - Coveralls

crates/chia-consensus/src/fast_forward.rs Outdated Show resolved Hide resolved
crates/chia-consensus/src/fast_forward.rs Outdated Show resolved Hide resolved
crates/chia-wallet/src/proof.rs Outdated Show resolved Hide resolved
crates/chia-wallet/src/puzzles/singleton.rs Outdated Show resolved Hide resolved
@Rigidity Rigidity requested a review from arvidn April 27, 2024 16:03
arvidn
arvidn previously approved these changes Apr 29, 2024
@Rigidity Rigidity merged commit 3467363 into main Apr 29, 2024
64 checks passed
@Rigidity Rigidity deleted the simplify-singleton-types branch April 29, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants