-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHIA-773] Swap out Payment
for CreateCoin
#19144
Open
Quexington
wants to merge
4
commits into
main
Choose a base branch
from
quex.deprecate_payment
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
added
the
Changed
Required label for PR that categorizes merge commit message as "Changed" for changelog
label
Jan 14, 2025
Quexington
changed the title
Swap out
[CHIA-773] Swap out Jan 15, 2025
Payment
for CreateCoin
Payment
for CreateCoin
github-actions
bot
added
the
merge_conflict
Branch has conflicts that prevent merge to main
label
Jan 17, 2025
geoffwalmsley
previously approved these changes
Jan 18, 2025
github-actions
bot
removed
the
merge_conflict
Branch has conflicts that prevent merge to main
label
Jan 21, 2025
Pull Request Test Coverage Report for Build 12895445105Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changed
Required label for PR that categorizes merge commit message as "Changed" for changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two types are essentially aliases for each other.
Payment
was earlier but whenCreateCoin
was made as part of thechia.wallet.conditions
PR, it was decided just to duplicatePayment
for simplicity. This PR removes that duplication in favor of the newer, more paradigmatic type.