Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHIA-773] Swap out Payment for CreateCoin #19144

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Quexington
Copy link
Contributor

@Quexington Quexington commented Jan 14, 2025

These two types are essentially aliases for each other. Payment was earlier but when CreateCoin was made as part of the chia.wallet.conditions PR, it was decided just to duplicate Payment for simplicity. This PR removes that duplication in favor of the newer, more paradigmatic type.

@Quexington Quexington added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Jan 14, 2025
@Quexington Quexington marked this pull request as ready for review January 14, 2025 17:56
@Quexington Quexington requested a review from a team as a code owner January 14, 2025 17:56
@Quexington Quexington closed this Jan 14, 2025
@Quexington Quexington reopened this Jan 14, 2025
@Quexington Quexington closed this Jan 15, 2025
@Quexington Quexington reopened this Jan 15, 2025
@Quexington Quexington changed the title Swap out Payment for CreateCoin [CHIA-773] Swap out Payment for CreateCoin Jan 15, 2025
@Quexington Quexington closed this Jan 16, 2025
@Quexington Quexington reopened this Jan 16, 2025
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jan 17, 2025
geoffwalmsley
geoffwalmsley previously approved these changes Jan 18, 2025
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jan 21, 2025
@Chia-Network Chia-Network deleted a comment from github-actions bot Jan 21, 2025
@Chia-Network Chia-Network deleted a comment from github-actions bot Jan 21, 2025
@Chia-Network Chia-Network deleted a comment from github-actions bot Jan 21, 2025
@Quexington Quexington closed this Jan 21, 2025
@Quexington Quexington reopened this Jan 21, 2025
Copy link

Pull Request Test Coverage Report for Build 12895445105

Details

  • 78 of 78 (100.0%) changed or added relevant lines in 21 files are covered.
  • 23 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.004%) to 91.518%

Files with Coverage Reduction New Missed Lines %
chia/wallet/util/wallet_sync_utils.py 1 86.14%
chia/wallet/puzzles/puzzle_utils.py 1 76.19%
chia/server/node_discovery.py 2 81.5%
chia/consensus/blockchain.py 2 94.14%
chia/timelord/timelord_launcher.py 2 89.29%
chia/wallet/wallet_node.py 4 88.03%
chia/timelord/timelord.py 11 78.52%
Totals Coverage Status
Change from base Build 12894248841: 0.004%
Covered Lines: 105287
Relevant Lines: 114869

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants