Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHIA-2221 Remove no longer needed has_peers_with_peak #19142

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CHIA-2221 Remove no longer needed has_peers_with_peak #19142

wants to merge 1 commit into from

Conversation

AmineKhaldi
Copy link
Contributor

This is not used as of 4b90197.

@AmineKhaldi AmineKhaldi added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup labels Jan 14, 2025
@AmineKhaldi AmineKhaldi self-assigned this Jan 14, 2025
@AmineKhaldi AmineKhaldi force-pushed the zap_has_peers_with_peak branch from f349eaa to 67d173a Compare January 15, 2025 15:37
@AmineKhaldi AmineKhaldi force-pushed the zap_has_peers_with_peak branch from 67d173a to dc525b8 Compare January 22, 2025 10:33
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 12906313466

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 37 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.005%) to 91.509%
Files with Coverage Reduction New Missed Lines %
chia/wallet/util/wallet_sync_utils.py 1 86.14%
chia/farmer/farmer_api.py 2 94.38%
chia/timelord/timelord_launcher.py 2 89.29%
chia/full_node/full_node.py 4 86.45%
chia/server/node_discovery.py 6 80.59%
chia/wallet/wallet_node.py 8 87.82%
chia/timelord/timelord.py 14 78.2%
Totals Coverage Status
Change from base Build 12894248841: -0.005%
Covered Lines: 105306
Relevant Lines: 114904
💛 - Coveralls

@AmineKhaldi AmineKhaldi marked this pull request as ready for review January 22, 2025 13:27
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner January 22, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

Assignees

@AmineKhaldi AmineKhaldi

Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmineKhaldi @arvidn