Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHIA-2220 Fix a typo when picking the best unfinished block in test_request_unfinished_block2 #19141

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AmineKhaldi
Copy link
Contributor

At this point, we already know that unf.foliage.foliage_transaction_block_hash is not None, but in order to compare it with our current best unfinished block, best_unf.foliage.foliage_transaction_block_hash must not be None as well.

@AmineKhaldi AmineKhaldi added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup labels Jan 14, 2025
@AmineKhaldi AmineKhaldi self-assigned this Jan 14, 2025
@AmineKhaldi AmineKhaldi force-pushed the best_unf_test_request_unfinished_block2 branch from 217bef3 to e1f1cb1 Compare January 15, 2025 15:38
@AmineKhaldi AmineKhaldi force-pushed the best_unf_test_request_unfinished_block2 branch from e1f1cb1 to feed626 Compare January 22, 2025 10:32
Copy link

Pull Request Test Coverage Report for Build 12906301067

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 29 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.001%) to 91.515%

Files with Coverage Reduction New Missed Lines %
chia/_tests/simulation/test_simulation.py 1 96.45%
chia/wallet/util/wallet_sync_utils.py 1 86.14%
chia/full_node/full_node_api.py 1 84.38%
chia/timelord/timelord_launcher.py 1 91.43%
chia/full_node/full_node.py 1 86.63%
chia/server/node_discovery.py 2 81.68%
chia/wallet/wallet_node.py 8 87.82%
chia/timelord/timelord.py 14 78.2%
Totals Coverage Status
Change from base Build 12894248841: 0.001%
Covered Lines: 105318
Relevant Lines: 114908

💛 - Coveralls

@AmineKhaldi AmineKhaldi marked this pull request as ready for review January 22, 2025 13:28
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner January 22, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants